> On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: > > part.cpp, line 286 > > <http://git.reviewboard.kde.org/r/104947/diff/3/?file=66271#file66271line286> > > > > Are you sure we need all this SettingsCore calls here? Seems a bit > > weird they are needed if Settings inherits from SettingsCore, no? > > Bogdan Cristea wrote: > The problem is that the back end uses only SettingsCore class to manage > settings and has no ideea of what is above, so in part.cpp both classes, > Settings and SettingsCore should be managed. On the other hand, the front end > needs to access all settings from a single access point (the instance of > Settings class), so Settings class should be derived from SettingsCore. > > Albert Astals Cid wrote: > Why? Settings *is* a SettingsCore, so I don't see the need of creating > one if you are already creating a Settings.
Indeed, it is possible to remove from part.cpp all references to SettingsCore. I have checked also that the settings are correctly saved and restored. - Bogdan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14433 ----------------------------------------------------------- On June 17, 2012, 10:27 p.m., Bogdan Cristea wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104947/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 10:27 p.m.) > > > Review request for Okular. > > > Description > ------- > > Default settings file should be separated in two different files in order to > have a better separation between okular core library (back end) and the front > end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request > includes only the separation of okular.kcfg in two files: > -okular.kcfg (front end) > -okular_core.kcfg (back end) > > > Diffs > ----- > > CMakeLists.txt 0034cf3 > conf/okular.kcfg 6ad0e19 > conf/okular_core.kcfg PRE-CREATION > conf/settings.kcfgc 0b70390 > conf/settings_core.kcfgc PRE-CREATION > core/document.cpp 0ebc34e > core/script/kjs_fullscreen.cpp c07ac4e > core/texteditors_p.h 171dc69 > okular.spec PRE-CREATION > part.cpp 4c6aac8 > ui/pagepainter.cpp ca55e81 > ui/pageview.cpp 4be5e6b > ui/presentationwidget.cpp a3b8be4 > > Diff: http://git.reviewboard.kde.org/r/104947/diff/ > > > Testing > ------- > > No > > > Thanks, > > Bogdan Cristea > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
