-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103194/#review8696
-----------------------------------------------------------


This review has been submitted with commit 
ac85f27474a71fbb2a9db1844519940d5d78d11c by Stephen Anthony to branch master.

- Commit Hook


On Nov. 20, 2011, 11:02 p.m., Stephen Anthony wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103194/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2011, 11:02 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The following patch addresses several issues with 'facing pages' mode:
> 
> 1)  Facing pages are now touching each other on the center dividing line, 
> instead of being centered within their own virtual column.  This makes the 
> output much more like reading from a book or magazine.
> 
> 2)  If "Center First Page" is activated, the last page of the document is 
> also centered *if* it would be in the view by itself.  Previously, this page 
> was always on the left.  It looks better to have the front and back covers 
> centered across the entire viewable area.
> 
> 3)  The "Facing Pages (Center First Page)"  has been renamed to "Book Mode", 
> to more clearly indicate its intent.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 56be30d 
> 
> Diff: http://git.reviewboard.kde.org/r/103194/diff/diff
> 
> 
> Testing
> -------
> 
> After making these changes, all view modes and continuous viewing were 
> tested.  The only behaviour that has changed is in "Facing Page" modes; the 
> behaviour of all other modes works the same as before.
> 
> 
> Thanks,
> 
> Stephen Anthony
> 
>

_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Reply via email to