> On Nov. 20, 2011, 10:47 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3722 > > <http://git.reviewboard.kde.org/r/103194/diff/1/?file=41580#file41580line3722> > > > > Please do not use >> 1, makes no sense and makes code far unreadable > > (applies for the other lines of this change too)
OK, the changes have been made. Please take a look at the new patch. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103194/#review8356 ----------------------------------------------------------- On Nov. 20, 2011, 11:02 p.m., Stephen Anthony wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103194/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2011, 11:02 p.m.) > > > Review request for Okular. > > > Description > ------- > > The following patch addresses several issues with 'facing pages' mode: > > 1) Facing pages are now touching each other on the center dividing line, > instead of being centered within their own virtual column. This makes the > output much more like reading from a book or magazine. > > 2) If "Center First Page" is activated, the last page of the document is > also centered *if* it would be in the view by itself. Previously, this page > was always on the left. It looks better to have the front and back covers > centered across the entire viewable area. > > 3) The "Facing Pages (Center First Page)" has been renamed to "Book Mode", > to more clearly indicate its intent. > > > Diffs > ----- > > ui/pageview.cpp 56be30d > > Diff: http://git.reviewboard.kde.org/r/103194/diff/diff > > > Testing > ------- > > After making these changes, all view modes and continuous viewing were > tested. The only behaviour that has changed is in "Facing Page" modes; the > behaviour of all other modes works the same as before. > > > Thanks, > > Stephen Anthony > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
