Yicong-Huang commented on code in PR #7785:
URL: https://github.com/apache/texera/pull/7785#discussion_r3896030133
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorService.scala:
##########
@@ -23,7 +23,6 @@ import org.apache.pekko
import pekko.actor.{ActorContext, ActorRef, Address, Cancellable, Props}
import pekko.util.Timeout
Review Comment:
Verified at `a36189aa`: `PekkoActorService.scala` no longer declares
`implicit val timeout`, and both members that existed only to type it are gone
with it — `pekko.util.Timeout` from the import list and `DurationInt` from
`scala.concurrent.duration`, which now imports `FiniteDuration` alone.
`implicit def ec` and `implicit val self` remain, both live. Resolving.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorService.scala:
##########
@@ -23,7 +23,6 @@ import org.apache.pekko
import pekko.actor.{ActorContext, ActorRef, Address, Cancellable, Props}
import pekko.util.Timeout
Review Comment:
Duplicate of the thread above — round 2 posted twice 76 seconds apart. Same
finding, fixed at `a36189aa`; resolving with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
