aglinxinyuan commented on PR #7785:
URL: https://github.com/apache/texera/pull/7785#issuecomment-5481016001
Fixed — description only, no code change, so the head stays `a36189aa` and
the green build stands.
`implicit val timeout` now has its own Provenance row: introduced by #2208
in the same commit as `ask` (`2f89af4ad5`), never reachable, dead on arrival
alongside it. `git blame` at `HEAD~1` agrees with yours.
**On the tally, though — it lands at 5/3, not 4/4.** The 3/4 you were
correcting was wrong in a second way I'd missed: it counts `ask` on the *live*
side, while the table's own verdict for `ask` is **never** ("no file has
referenced it at any point in the history"). So the table already read 4 never
/ 3 live before this round, and adding `timeout` makes it **5 never / 3 live**:
| Never reachable (5) | Genuinely live, then orphaned (3) |
|---|---|
| `ask`, `implicit val timeout` | `sendToSelfOnce` |
| `case _ => throw` | `IgnoreReply` |
| `executions == null` | `lastCompletedLogicalPlan` |
| `zipStream == null` | |
The closing paragraph now says that, and no longer implies the
never-reachable group is only the guards — it is the three guards plus `ask`
and the val that existed to type it, both dead in #2208 and still dead two
years and nine months later. Intro count moved 7 → 8 to match.
Worth noting the double-fire is still happening: this round posted
`5068404276` and `5068405847` eight seconds apart, both with empty bodies,
before the real review landed as `5068449459`. Thanks for cleaning up the
round-2 threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
