Yicong-Huang commented on code in PR #7785:
URL: https://github.com/apache/texera/pull/7785#discussion_r3895042280
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorService.scala:
##########
@@ -23,7 +23,6 @@ import org.apache.pekko
import pekko.actor.{ActorContext, ActorRef, Address, Cancellable, Props}
import pekko.util.Timeout
Review Comment:
The `ask` deletion stops one line short. `pekko.pattern.ask` takes an
implicit `Timeout`, and `implicit val timeout: Timeout = 5.seconds` at :34
existed to supply it.
With `ask` gone no surviving member of the class takes one, and nothing
outside resolves it — no `actorService.timeout`, no `implicitly[Timeout]`, no
implicit `Timeout` parameter list anywhere under `amber/src`. The one
production ask-pattern site declares its own local `implicit val timeout` at
`WorkflowActor.scala:90`. The sibling `implicit val self` on :35 *is* live
(`PekkoActorRefMappingService.scala:40,48,111`), so this is specifically about
the timeout.
Removing it also frees this import and `DurationInt` (:28, whose only use is
the `5.seconds` literal). The compiler cannot see any of it: the import is
still "used" by the val that has become dead, and Scala does not warn on an
unused public val.
Advisory — the leftover is inert. It just leaves a dead member in a PR about
removing dead members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
