Xiao-zhen-Liu commented on PR #5966: URL: https://github.com/apache/texera/pull/5966#issuecomment-4845675640
@carloea2 thanks, addressed all three: 1. **Non-empty `OpExecInitInfo` test** — added: two operators differing only in their `OpExecWithCode(code, "python")` produce different cache keys, which confirms exec info is part of the identity and exercises the non-empty `serializeOpExec` path. 2. **Validating `target`** — kept it a pure internal helper rather than a runtime check. Its contract is that the caller passes an output port and the sub-DAG that produces it (`plan.getTransitiveUpstreamSubPlan(target.opId)`); I documented that in the scaladoc. 3. **`OutputPort.mode` / `blocking` / `reuseStorage`** — none are in the cache identity, and I added a test documenting that. `mode` only controls how stored tuples are presented to the UI (snapshot vs delta vs single-snapshot); every tuple is written to storage identically regardless of mode, and it's fixed by the operator type, so it's already implied by the operator identity in the hash. `blocking` (scheduling) and `reuseStorage` (storage) likewise don't change the materialized data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
