carloea2 commented on PR #5966: URL: https://github.com/apache/texera/pull/5966#issuecomment-4840855342
**Comment 1** Could we add a `CacheKeyUtil` test with a non-empty `OpExecInitInfo`, such as `OpExecWithClassName(..., descString)` or `OpExecWithCode(...)`? **Comment 2** Should `computeCacheKey` validate that `target` is an output port and belongs to the provided sub-DAG, or is that expected to be enforced by callers? **Comment 3** Should fields like `OutputPort.mode`, `blocking`, or `reuseStorage` be included in the cache identity, or should we add a test documenting that they are intentionally ignored? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
