Xiao-zhen-Liu commented on PR #5966: URL: https://github.com/apache/texera/pull/5966#issuecomment-4835103947
Thanks @Yicong-Huang — pushed changes addressing these (replies inline). Summary: renamed to `StorageCacheKey` / `isSameComputation` / `buildJSONPayload`; moved the upstream collection into `PhysicalPlan.getTransitiveUpstreamSubPlan(opId)` and dropped `SubDag` so `computeCacheKey` takes a sub-DAG; the test now lives in workflow-core (so the code is covered in its own module). Two I kept, with reasoning inline: deriving the JSON mapper from `JSONUtils.objectMapper` rather than reusing it directly (determinism needs `ORDER_MAP_ENTRIES_BY_KEYS`), and hashing `opExecInitInfo` rather than the Desc. Retitled to `feat(workflow-core)` since nothing remains in amber. Re-requesting your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
