Vitor-Avila commented on code in PR #33626:
URL: https://github.com/apache/superset/pull/33626#discussion_r2124094568
##########
tests/integration_tests/datasets/api_tests.py:
##########
@@ -1188,6 +1190,10 @@ def test_update_dataset_create_column_and_metric(self):
metric.pop("type_generic", None)
data["result"]["metrics"].append(new_metric_data)
+
+ # Sleep to ensure that the changed_on is updated
Review Comment:
ok, this is done now! 🙌 I'll work on a follow up to remove `time.sleep()`
from other places I found in the code. I'll probably combine that with a
deprecation of `datetime.now()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
