Vitor-Avila commented on code in PR #33626:
URL: https://github.com/apache/superset/pull/33626#discussion_r2123720949


##########
tests/integration_tests/datasets/api_tests.py:
##########
@@ -1188,6 +1190,10 @@ def test_update_dataset_create_column_and_metric(self):
             metric.pop("type_generic", None)
 
         data["result"]["metrics"].append(new_metric_data)
+
+        # Sleep to ensure that the changed_on is updated

Review Comment:
   @michael-s-molina thank you 🙏 I used that in another test, but here I 
intentionally want to confirm that the new value for `changed_on` is more 
recent than the old one, so this should be sufficient. I wanted to avoid 
mocking it to ensure the logic is properly applied.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to