Vitor-Avila commented on code in PR #33626: URL: https://github.com/apache/superset/pull/33626#discussion_r2123857508
########## superset/connectors/sqla/models.py: ########## @@ -2072,8 +2056,6 @@ def load_database(self: SqlaTable) -> None: sa.event.listen(SqlaTable, "before_update", SqlaTable.before_update) sa.event.listen(SqlaTable, "after_insert", SqlaTable.after_insert) sa.event.listen(SqlaTable, "after_delete", SqlaTable.after_delete) -sa.event.listen(SqlMetric, "after_update", SqlaTable.update_column) Review Comment: @michael-s-molina the only other place I found that was modifying these is via import flows, which I manually tested and confirmed it is updating the `changed_on` as well, so I believe we're good. Other than that I found some migrations. If we find other places in the future, happy to do a follow up tho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
