amaannawab923 commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2096793773


##########
superset-frontend/packages/superset-ui-core/src/chart/types/VizType.ts:
##########
@@ -54,6 +54,7 @@ export enum VizType {
   Step = 'echarts_timeseries_step',
   Sunburst = 'sunburst_v2',
   Table = 'table',
+  TableAgGrid = 'table_ag_grid',

Review Comment:
   <img width="1358" alt="Screenshot 2025-05-20 at 8 45 57 AM" 
src="https://github.com/user-attachments/assets/912ce158-366d-46c0-98d1-3f3bb7cd154e";
 />
   
   Another issue @justinpark  @michael-s-molina  , Any component that is used 
in viz plugin must be part of @superset-ui/core ... if we try to use a 
Component from src/components in viz plugin , we start getting errors , Should 
we move the Grid Table to superset-ui/core



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to