amaannawab923 commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2096391619
##########
superset-frontend/packages/superset-ui-core/src/chart/types/VizType.ts:
##########
@@ -54,6 +54,7 @@ export enum VizType {
Step = 'echarts_timeseries_step',
Sunburst = 'sunburst_v2',
Table = 'table',
+ TableAgGrid = 'table_ag_grid',
Review Comment:
Hey @justinpark — happy to collaborate on this! 😊
I ran into a couple of issues with the AG Grid integration in SQL Lab that I
wanted to highlight:
1. AG Grid styles not applying correctly 🎨
The default AG Grid table in SQL Lab doesn’t seem to reflect the standard AG
Grid themes.
Here's a screenshot showing the current state:
<img width="1370" alt="Screenshot 2025-05-20 at 1 13 01 AM"
src="https://github.com/user-attachments/assets/356cedf5-542c-43b2-bd19-d735cd993ca4";
/>
In comparison, the AG Grid demo (https://www.ag-grid.com/example-finance/)
looks much more polished.
To fix this, I manually imported the AG Grid styles from the node_modules
directory into a separate CSS file. After doing so, the table styling aligned
much better with AG Grid’s intended design:
<img width="1192" alt="Screenshot 2025-05-20 at 1 11 51 AM"
src="https://github.com/user-attachments/assets/8f85188c-fc90-4f5b-a5d8-c70018fd1f5b";
/>
2. Missing column filters due to custom headers 🚫🔍
Currently, it looks like we’re losing out on the built-in column filters
because of our custom header implementation:
<img width="1509" alt="Screenshot 2025-05-20 at 1 15 28 AM"
src="https://github.com/user-attachments/assets/247449cd-9bf8-4cc6-a9cd-dcb6a0d84bed";
/>
This can be resolved by implementing the column menu as an inner header
component, as documented here:
https://www.ag-grid.com/javascript-data-grid/column-headers/#inner-header-component
That way, we can retain the native column filtering capabilities while
customizing the header.
✅ If we address these two points, we should be in a solid position to
standardize on a common AG Grid table component.
cc: @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
