michael-s-molina commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2096201645
##########
superset-frontend/packages/superset-ui-core/src/chart/types/VizType.ts:
##########
@@ -54,6 +54,7 @@ export enum VizType {
Step = 'echarts_timeseries_step',
Sunburst = 'sunburst_v2',
Table = 'table',
+ TableAgGrid = 'table_ag_grid',
Review Comment:
Thanks for the PR @amaannawab923. Some questions from the PR review meeting
1 - Do we need separate visualizations or the intention should be to replace
the current table with Ag Grid. The thinking here is that it would be nice to
be able to support only one table in Superset. @michael-s-molina
2 - We should probably use `table_v2` instead of `table_ag_grid`.
@sadpandajoe
3 - We should use the same component created for SQL Lab. @justinpark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
