Vitor-Avila commented on PR #33214:
URL: https://github.com/apache/superset/pull/33214#issuecomment-2824543087

   @rusackas I think this was already the case before. @kgabryje recently 
refactored the dashboard loading for performance improvements 
(https://github.com/apache/superset/pull/31241), and if you check the 
`superset-frontend/src/dashboard/containers/Chart.jsx` file in there `maxRows` 
was already set it this way:
   ```
   ...
   maxRows: common.conf.SQL_MAX_ROW,
   ...
   ```
   
   I thought about that too (we don't heavily expose this FF in Preset so I 
wasn't sure) but I think it always had this "precautionary" measure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to