rusackas commented on PR #33214: URL: https://github.com/apache/superset/pull/33214#issuecomment-2824521128
If I understand correctly, the FF currently lets you grab the entire table regardless of SQL_MAX_ROW. On the one hand, I appreciate this fix, as such a feature could nuke the DB and melt your computer. On the other hand, this is a departure from behavior some people have come to expect. It's _kind of_ a breaking change, but that's debatable... this almost feels like a bug fix given the above. Nevertheless, I think there should be a note in UPDATING.md about it, and if you want bonus points, maybe we could surface a tooltip or something that propagates SQL_MAX_ROW so the user knows how many rows they can expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
