Vitor-Avila opened a new pull request, #33214: URL: https://github.com/apache/superset/pull/33214
### SUMMARY This is a follow up to https://github.com/apache/superset/pull/31241 and https://github.com/apache/superset/pull/31720. When the `ALLOW_FULL_CSV_EXPORT` FF is enabled, it's possible to download the entire table results (up to the `SQL_MAX_ROW` config). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Enable the `ALLOW_FULL_CSV_EXPORT` FF. 2. Set `SQL_MAX_ROW` to `100000`. 3. Create a table chart using the `flights` dataset with the row limit set to `15000` and add it to a dashboard. 4. Access the dashboard. 5. Click on the chart menu, then **Download > Export to .CSV**. Validate the file includes 15k rows of data. 6. Click on the chart menu, then **Download > Export to full .CSV**. Validate the file includes ~55k rows of data. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
