LevisNgigi commented on code in PR #33196:
URL: https://github.com/apache/superset/pull/33196#discussion_r2055449883
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -294,6 +343,11 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
{this.renderHeader(
Math.ceil(headerFontSize * (1 - PROPORTION.TRENDLINE) * height),
)}
+ {this.rendermetricComparisonSummary(
+ Math.ceil(
+ subheaderFontSize * (1 - PROPORTION.TRENDLINE) * height,
Review Comment:
We can,this means the subheader font size in the UI needs updating
[here](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/sharedControls.ts#L91)
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
