Vitor-Avila commented on PR #33196: URL: https://github.com/apache/superset/pull/33196#issuecomment-2826298983
Performed below manual tests on my end: 1. Spin up Superset from sha/commit `164a07e2be7854520070a7d845eec449405c4840` (last one before the PR that introduced `subtitle` - [ref](https://github.com/apache/superset/commit/164a07e2be7854520070a7d845eec449405c4840)). 2. Created 5 Big Numbers (one for each subheader font size) and added them to a dashboard. 3. Did the same with the Big Number and Trendline chart type. 4. Checked out to commit `d75ff9e784ca571e8498febb3b492874118312c8` (the one introducing subtitles - [ref](https://github.com/apache/superset/commit/d75ff9e784ca571e8498febb3b492874118312c8)). 5. Validated that the subheader text have disappeared for the Big Numbers. Big Numbers with Trendline were still ok. 6. Created 5 more Big Numbers using the new schema (with `subtitle`) and added to the same dashboard. 7. Checked out to commit `41402617970368f0b14ff4e7acc1d271d5bcdd89` (the one that fixes the missing headers - [ref](https://github.com/apache/superset/commit/41402617970368f0b14ff4e7acc1d271d5bcdd89)). Validated that the Big Numbers are now showing the headers. Big Number with Trendline no longer show the subtitle. Also, the subtitle font sizes would show correct in the dashboard, but when accessing the charts in Explore they would always show up as **Small** (default value). 8. Checked out to this PR. Validated that: - Subheaders for Big Numbers with Trendlines are back. ✅ - Their font size is showing correctly both in charts and dashboards. ✅ - The subtitle for Big Numbers appear duplicated: 🔴 <img width="1758" alt="image" src="https://github.com/user-attachments/assets/6d16fb73-2aa9-4227-9c3a-9b59e35baadd"; /> - Accessing the chart in Explore does not show the subtitle content (the subtitle size is also not correct): 🔴 <img width="1334" alt="image" src="https://github.com/user-attachments/assets/14f9e358-1cbf-41d1-bc90-55f4e9078feb"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
