eschutho commented on code in PR #33196:
URL: https://github.com/apache/superset/pull/33196#discussion_r2054932008
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -188,19 +188,21 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
);
}
- renderSubtitle(maxHeight: number) {
- const { subtitle, width } = this.props;
+ rendermetricComparisonSummary(maxHeight: number) {
+ const { subheader, width } = this.props;
let fontSize = 0;
- if (subtitle) {
+ const text = subheader;
+
+ if (text) {
const container = this.createTemporaryContainer();
document.body.append(container);
try {
fontSize = computeMaxFontSize({
- text: subtitle,
+ text,
maxWidth: width * 0.9,
maxHeight,
- className: 'subtitle-line',
+ className: 'subheader-line',
Review Comment:
```suggestion
className: 'metrics-comparison-line',
```
Can we also rename this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
