eschutho commented on code in PR #33196:
URL: https://github.com/apache/superset/pull/33196#discussion_r2052945429
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -188,6 +188,47 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
);
}
+ renderSubheader(maxHeight: number) {
+ const { bigNumber, subheader, width, bigNumberFallback } = this.props;
+ let fontSize = 0;
+
+ const NO_DATA_OR_HASNT_LANDED = t(
+ 'No data after filtering or data is NULL for the latest time record',
+ );
+ const NO_DATA = t(
+ 'Try applying different filters or ensuring your datasource has data',
+ );
+ let text = subheader;
+ if (bigNumber === null) {
+ text = bigNumberFallback ? NO_DATA : NO_DATA_OR_HASNT_LANDED;
Review Comment:
I'm also thinking that if we were to use this component only for metrics
comparisons, then we can move this fallback text to the subtitle instead. How
does that sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
