fardin-developer commented on code in PR #33099:
URL: https://github.com/apache/superset/pull/33099#discussion_r2048265901
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts:
##########
@@ -91,11 +96,16 @@ export default function transformProps(chartProps:
ChartProps) {
percentDifferenceFormat,
subtitle = '',
subtitleFontSize,
- columnConfig,
+ columnConfig = {},
} = formData;
const { data: dataA = [] } = queriesData[0];
const data = dataA;
const metricName = metric ? getMetricLabel(metric) : '';
+ const metricKey = metric ? getMetricLabel(metric) : '';
Review Comment:
Thanks for the update! I’ve moved the originalLabel logic into a separate
getOriginalLabel function and updated it to address issues where the metric key
was incorrectly displayed in some cases. The new implementation now works as
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
