Antonio-RiveroMartnez commented on code in PR #33099:
URL: https://github.com/apache/superset/pull/33099#discussion_r2047126712
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/controlPanel.ts:
##########
@@ -70,6 +71,28 @@ const config: ControlPanelConfig = {
],
[subtitleControl],
[subtitleFontSize],
+ [
Review Comment:
Could we create a control we can reuse instead of defining this on all 3
charts every time? something like how you use `subtitleControl ` for example?
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts:
##########
@@ -91,11 +96,16 @@ export default function transformProps(chartProps:
ChartProps) {
percentDifferenceFormat,
subtitle = '',
subtitleFontSize,
- columnConfig,
+ columnConfig = {},
} = formData;
const { data: dataA = [] } = queriesData[0];
const data = dataA;
const metricName = metric ? getMetricLabel(metric) : '';
+ const metricKey = metric ? getMetricLabel(metric) : '';
Review Comment:
Same with this block, could this be some sort of util we can reuse in the 3
chart types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
