fardin-developer commented on code in PR #33099:
URL: https://github.com/apache/superset/pull/33099#discussion_r2047076624
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts:
##########
@@ -26,7 +26,12 @@ import {
SimpleAdhocFilter,
ensureIsArray,
} from '@superset-ui/core';
-import { getComparisonFontSize, getHeaderFontSize } from './utils';
+import {
+ getComparisonFontSize,
+ getHeaderFontSize,
+ getMetricNameFontSize,
+} from './utils';
+import { getFriendlyMetricName } from '../utils';
Review Comment:
Thanks @Antonio-RiveroMartnez . I’ve removed that way of getting the
friendlyName and simplified it directly within transformProps — we no longer
need that function. Also, yes, I agree it makes sense to extract and reuse it
in both Table Chart and Big Number.
I’m planning to create a separate issue for that and will try to merge both
implementations accordingly. Do you think that approach would work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
