mistercrunch commented on PR #32707: URL: https://github.com/apache/superset/pull/32707#issuecomment-2799002812
> do I need to implement something for the persistency in the database? Nope, this will happen on its own. As you alter the controls and related logic in the database, all of this automatically end up in serialized JSON payload for the chart given chart. For reference, I'm pretty sure it lands in here -> https://github.com/apache/superset/blob/347c1740998bba767ce05a42a969f1fb295d1479/superset/models/slice.py#L80 . Another interesting to know is around "what happens with the missing params for older charts?". The short answer is we simply use the defaults defined for the unreferenced controls when loading the chart, so it's important to make sure that defaults won't change the charts in anyways. Now in some fairly rare cases where we want to change control semantics or structure, it sometimes requires a chart database migration, where it's possible to alter the `params` strucuture of existing charts. I don't think we need anything like that in this particular case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
