jpchev commented on PR #32707: URL: https://github.com/apache/superset/pull/32707#issuecomment-2820591725
> Added a test chart [here](http://35.167.64.30:8080/explore/?form_data_key=BtybBq-eASA&slice_id=121&save_action=saveas). Controls look a lot cleaner with the conditional rendering now, thank you! Seems to work well in both vertical and horizontal mode. I still feel the dimension added to "Stack by" feels more like a "Split by" or "Create Stacks for" but again, maybe it's just me expecting "Stack by" to be the dimension that IS stacked. I think the tooltip does help explain the situation, though. Good, thanks for reviewing, can we consider having the feature merged? I can change the labels if that's better (replace "Stack by") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
