rusackas commented on PR #32707: URL: https://github.com/apache/superset/pull/32707#issuecomment-2794372454
> > Also, just kicking the tires here, I'm a little bit unsure of this working correctly. On the ephemeral/test workspace, I set up >[this chart](http://35.93.186.138:8080/explore/?form_data_key=dPlqmlkSov4&slice_id=121). As you'll see, if you "stack by" >with the "status" column, you get a stack of countries, and if you "stack by" the "country" column, you get a stack of >statuses per country. It feels like the logic is inverted. > > Isn't "stack by" intended as "group by" in SQL ? > > If you stack by status, you get one vertical stack per each status (a "group" per each status), where each segment in the vertical stack is a country (the other dimension). If you stack by country, you get one vertical stack per each country (a "group" per each country), where each segment in the vertical stack is a status (the other dimension). > > That's the behaviour of the "stack" parameter in Apache Echarts: "_The value of stack explained what series will be stacked up together_" > > see https://echarts.apache.org/handbook/en/how-to/chart-types/bar/stacked-bar/ Ahh... I see your logic. I guess this is a bit of confusion on my part, but I can't help but wonder if I'm alone here. When you say "stack by," and select "country" I was expecting to see a stack of countries. In the current code, it's what I'd expect for a "split by" or "group by" control. It's a little weird to me that you select "stack by" and that's not what's stacked up! Curious if @villebro / @mistercrunch / @kasiazjc have opinions on the matter. I'd be OK merging this as-is, if others are happy with it. The confusion may be all mine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
