tshallenberger commented on code in PR #32264:
URL: https://github.com/apache/superset/pull/32264#discussion_r1956588685
##########
superset-frontend/packages/superset-ui-chart-controls/src/utils/D3Formatting.ts:
##########
@@ -60,6 +60,10 @@ export const D3_FORMAT_OPTIONS: [string, string][] = [
['DURATION_COL', t('Duration in ms (10500 => 0:10.5)')],
['MEMORY_DECIMAL', t('Memory in bytes - decimal (1024B => 1.024kB)')],
['MEMORY_BINARY', t('Memory in bytes - binary (1024B => 1KiB)')],
+ [NumberFormats.BYTES_SI, 'Bytes in SI (kB, MB)'],
+ [NumberFormats.BYTES_IEC, 'Bytes in IEC (kiB, MiB)'],
+ [NumberFormats.BYTERATE_SI, 'Byterate in SI (kB/s, MB/s)'],
+ [NumberFormats.BYTERATE_IEC, 'Byterate in IEC (kiB/s, MiB/s)'],
Review Comment:
The lowercase k can be synonymous with uppercase K when dealing with kilo /
kibi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
