tshallenberger commented on code in PR #32264: URL: https://github.com/apache/superset/pull/32264#discussion_r1956554022
########## superset-frontend/packages/superset-ui-core/src/number-format/NumberFormats.ts: ########## @@ -54,6 +54,13 @@ const SMART_NUMBER = 'SMART_NUMBER'; const SMART_NUMBER_SIGNED = 'SMART_NUMBER_SIGNED'; const OVER_MAX_HIDDEN = 'OVER_MAX_HIDDEN'; +const BYTES_SI = 'BYTES_SI'; +const BYTES_IEC = 'BYTES_IEC'; +const BITRATE_SI = 'BITRATE_SI'; +const BYTERATE_SI = 'BYTERATE_SI'; +const BITRATE_IEC = 'BITRATE_IEC'; +const BYTERATE_IEC = 'BYTERATE_IEC'; Review Comment: False flag I think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
