tshallenberger opened a new pull request, #32264: URL: https://github.com/apache/superset/pull/32264
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> At Yahoo we needed custom number formatters for data transfer rates, in either IEC or Standard format. This change adds the following NumberFormats: ``` Bytes (SI) Byterate (SI) Bytes (IEC) Byterate (IEC) ``` Where SI records rates in terms of gigabyte, terabyte, and petabytes, and IEC records rates in terms of gibibytes, tebibytes, and pebibytes. The number formatter expects absolute values in bytes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> <img width="502" alt="image" src="https://github.com/user-attachments/assets/26d62224-df31-4eaa-a406-44725e421453"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create a Big Number chart for any dataset 2. Add a metric with custom sql for the value: `123456789` 3. Nav to Customize > Chart Options > Number Format and select either Bytes (SI), Bytes (IEC), Byterate (SI), Byterate (IEC) 4. You should see either of the following for your selection: Bytes (SI): 123.46 MB Byterate (SI): 123.46 MB/s Bytes (IEC): 117.74 MiB Byterate (IEC): 117.74 MiB/s ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
