geido commented on code in PR #31575:
URL: https://github.com/apache/superset/pull/31575#discussion_r1905816267
##########
superset-frontend/src/components/Label/index.tsx:
##########
@@ -25,6 +25,8 @@ import {
import { Tag } from 'src/components';
Review Comment:
It looks like we are pulling `Tag` directly from Ant Design instead of the
recommended approach which is to pull it from a wrapped component (which we
have, not sure how it fits with this though). My concern is that when we
migrate `Tag` to Ant Design version 5 some of these changes might need to be
reworked. Could this be a good time to upgrade `Tag` to Ant Design 5 and pull
it from the wrapper component everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
