mistercrunch commented on code in PR #31575:
URL: https://github.com/apache/superset/pull/31575#discussion_r1907740212
##########
superset-frontend/src/components/Label/index.tsx:
##########
@@ -25,6 +25,8 @@ import {
import { Tag } from 'src/components';
Review Comment:
wait I thought that line meant we're pulling from `src/components` as
opposed to antd-v5, which is the prescribed way. Maybe you mean that
`src/components/Tag` should it self wrapped Tag in a `styled` thing? I think
the more vanilla the better.
Maybe the hard rule should be "no-direct-antd-imports!" and maybe even
enforce with eslint eventually. But having `src/component` just be a redirect
is fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
