Re: [PR] feat: redesign labels [superset]

Tue, 07 Jan 2025 09:17:07 -0800 


kasiazjc commented on PR #31575:
URL: https://github.com/apache/superset/pull/31575#issuecomment-2575835425

   > Realign labels to look and feel closer to native AntD while integrating 
the theme colors.
   > 
   > As part of this PR:
   > 
   > * modify  to look and feel like native AntD
   > * adjust theme colors for primary/secondary/grayscale to align 
brightness-wise, mostly so that `.light2` lines up across the board
   > * Created a reusable label for DatasetTypeLabel and use it it CRUD list 
view
   > * Creating a PublishedLabel to use for dashboard in header + CRUD
   > * Improvements to storybooks: theme color to line up side by side
   > * Improvement to Label storybook, more interactive
   > 
   > ### label storybook
   > <img alt="Screenshot 2024-12-19 at 5 01 47 PM" width="1002" 
src="https://private-user-images.githubusercontent.com/487433/397578074-38c31983-c36e-436d-aaf7-a21e1ba5e4a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNzAxOTYsIm5iZiI6MTczNjI2OTg5NiwicGF0aCI6Ii80ODc0MzMvMzk3NTc4MDc0LTM4YzMxOTgzLWMzNmUtNDM2ZC1hYWY3LWEyMWUxYmE1ZTRhNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwN1QxNzExMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01OTJiODhmM2ZiMDBkZWVkNTBhNjJiZGVjY2VkYjdhMzhiNTUxN2IxMWU3MWViZmI3MDdjNjAyMzIwZTU0ODNlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Dr7JmBy_F8qY-cvF5X6yvW5k1OIFaDDqg_OLa6Q9Dww";>
   > ### dashboard header
   > <img alt="Screenshot 2024-12-19 at 5 02 16 PM" width="623" 
src="https://private-user-images.githubusercontent.com/487433/397578064-237271dc-ca79-4d83-8581-60268e136e1b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNzAxOTYsIm5iZiI6MTczNjI2OTg5NiwicGF0aCI6Ii80ODc0MzMvMzk3NTc4MDY0LTIzNzI3MWRjLWNhNzktNGQ4My04NTgxLTYwMjY4ZTEzNmUxYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwN1QxNzExMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNjc4NDZhNTI5ZjIxZWMwMzIxNzFiMDlkNWNmY2M2OTkwOGRhM2Y3MDkyODhkYzc3YzY3MGZhM2YyOWUyZmE1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7jIdprNW6qUfhMUtDNg8qQcfYmw1qO_4Ij40edCSixQ";>
   > ### crud view datasets
   > <img alt="Screenshot 2024-12-19 at 5 02 04 PM" width="903" 
src="https://private-user-images.githubusercontent.com/487433/397578068-2aa23acb-e6e0-43c1-a47c-56e2f46d3b86.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNzAxOTYsIm5iZiI6MTczNjI2OTg5NiwicGF0aCI6Ii80ODc0MzMvMzk3NTc4MDY4LTJhYTIzYWNiLWU2ZTAtNDNjMS1hNDdjLTU2ZTJmNDZkM2I4Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwN1QxNzExMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMTA0NTFjNTdmODRjMDI1MzhmNjdjNzM3YjM0YzZlOTEyZTJlNDZmODQxOGUzNDIwZWNlMzI5NGRhZmRmNDMzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.or88NRR71Abn-QFmol0dFoGF1UiXqV4HJDPIdbrMKQo";>
   > ### crud view dashboards
   > <img alt="Screenshot 2024-12-19 at 5 41 32 PM" width="795" 
src="https://private-user-images.githubusercontent.com/487433/397587052-b901e439-8479-4b2b-aa4f-5655f11bf15b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNzAxOTYsIm5iZiI6MTczNjI2OTg5NiwicGF0aCI6Ii80ODc0MzMvMzk3NTg3MDUyLWI5MDFlNDM5LTg0NzktNGIyYi1hYTRmLTU2NTVmMTFiZjE1Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwN1QxNzExMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hY2EzODcyNmU1ZTllMmZhNDhiOTAxZGVkODYxMDI0ZjQ0ZjlkNGVmNzljMTQ1ZmY1NzZhMjhjYjZjMTZmZmMzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9._ntitSDnsoTlxf1_LDb8iO5fW1v1ktGjPpi9VtwnzSY";>
   > ### explore
   > <img alt="Screenshot 2024-12-19 at 5 41 54 PM" width="535" 
src="https://private-user-images.githubusercontent.com/487433/397587050-897cbd88-0a02-4d2c-bb35-3988af4901cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNzAxOTYsIm5iZiI6MTczNjI2OTg5NiwicGF0aCI6Ii80ODc0MzMvMzk3NTg3MDUwLTg5N2NiZDg4LTBhMDItNGQyYy1iYjM1LTM5ODhhZjQ5MDFjYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEwN1QxNzExMzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZDBmMTZhZWUwNWI4YzE0NmE5NzUzMWFlYmYyNTIzMjY4NzdiMmMwOTVjNmRhZDk3OTNhMzNmY2UxZGVjM2I1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YOIbcZn0mwxMGlSPBhN76OSUtp6hoMgO-iTlY5NxRy0";>
   
   Love the change! One thing I would suggest is to keep green for 
published/checked/done etc, and use some other color (secondary?) for virtual 
datasets. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to