zxs1633079383 commented on PR #37216:
URL: https://github.com/apache/shardingsphere/pull/37216#issuecomment-3601771079
Hi @terrymanu,
Following your feedback, I have created a new PR #37259, which includes:
1. All functional changes from this PR (#37216)
These include the fixes for:
PostgreSQL custom types (UDT/enum/domain/composite)
VARBIT / BIT VARYING
Extended protocol: Parse → Bind → Describe → Execute
typeName propagation across metadata and prepared statements
2. All required test updates
Because typeName was added to:
ColumnMetaData
ShardingSphereColumn
ColumnReviseEngine
binder & extended protocol structures
many unit tests and E2E tests needed adjustments.
The new PR (#37259) includes all these test updates, ensuring that the full
CI pipeline passes after running:
./mvnw spotless:apply -Pcheck
./mvnw clean install -B -T1C -Pcheck
📌 Purpose of splitting
To keep this PR (#37216) focused and easy to review, I intentionally did not
include the large amount of test modifications here.
The new PR provides the complete, CI-passing version and can be used as the
final merge target.
If you prefer, I can also merge the test updates back into this PR, but
creating a separate complete PR seemed clearer based on your earlier suggestion
of reducing change size.
I’m very open to any further adjustments.
Thank you again for your time and guidance — happy to keep improving
ShardingSphere’s PostgreSQL support together!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
