zxs1633079383 commented on PR #37216:
URL: https://github.com/apache/shardingsphere/pull/37216#issuecomment-3592229822
@terrymanu Thank you again for the detailed review and guidance.
This is my first time contributing to an open-source project of this size.If
there is anything I am not handling correctly, please kindly point it out —I
will strictly follow your suggestions. I really hope to contribute to
thePostgreSQL custom UDT support together with the community.
Regarding the PR size:
After removing all unrelated dialect changes and restoring the enum to a
pure/immutable design, the scope has already been reduced significantly.
The current version now touches 18 files, all of which are tightly
related to the PostgreSQL extended-protocol path
(Parse → Describe → Bind → Metadata).
At this point, the PR is coherent and its intention is clear.However, if you
would still prefer to split it further into sub-PRs (each under 10 classes), I
am absolutely willing to do so.
Before proceeding, could you please confirm whether:
• the current 18-file PR is acceptable for review,
or
• you would like me to break it into several smaller PRs?
If splitting is required, I can reorganize the changes according to clear
module boundaries, for example:
1. Column metadata layer
- ColumnMetaData / ShardingSphereColumn adjustments
- typeName propagation
- YamlColumnSwapper and metadata conversion logic
2. PostgreSQL dialect loader
- PostgreSQLDataTypeLoader
- loading of enum/domain/composite types
- VARBIT and BIT VARYING metadata handling
3. PostgreSQL type system
- PostgreSQLColumnType enum refinements
- JSON/JSONB/VARBIT/UUID detection
- related text/binary parsers
4. Extended-protocol flow (Parse → Describe → Bind)
- parameter type collection
- typeName resolution in Describe
- PGobject construction and safe fallback in Bind
5. PostgreSQL-only tests
- JSON/JSONB OID correctness
- VARBIT parsing/handling
- UDT typeName propagation and Bind behavior
Or I can follow any grouping you prefer.
My goal is to keep the changes clear, focused, and low-risk so that the
review process becomes easier for everyone.
Thank you again for your patience and guidance. I will update the PR
immediately according to your confirmation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
