zxs1633079383 commented on PR #37216:
URL: https://github.com/apache/shardingsphere/pull/37216#issuecomment-3591696251
Thank you for the detailed review and clarification.
I have now narrowed this PR strictly to the PostgreSQL custom type / VARBIT
scope and reverted all unrelated edits across other dialects and metadata
loaders. The change surface is minimized and focused.
Summary of completed fixes:
1. Restored correct JSON / JSONB OIDs (114 / 3802).
2. Removed the mutable state from PostgreSQLColumnType:
- dropped typeName field
- removed withTypeName()
- enum is now pure and stateless again.
3. Restored the original JDBC type mapping logic, and added explicit
detection for JSON / JSONB / VARBIT / UUID without altering global
enum mappings.
4. Removed placeholder / non-English strings ("占位") from all metadata
and tests.
5. Reverted all non-PostgreSQL tests and code paths which were modified
earlier. Only PostgreSQL code is touched now.
6. Centralized JSON / JSONB / UDT PGobject construction in the Bind phase
with safe fallback typeName handling to prevent Bind-time
NPE/SQLException.
These changes now address the core regressions described in your review.
Remaining work:
- Add/adjust PostgreSQL-only tests for:
• JSON / JSONB OIDs unchanged
• VARBIT handling
• UDT binding (with and without typeName)
• No shared state across statements/sessions
I have already restored PostgreSQLColumnTypeTest and added JSON/JSONB and
VARBIT assertions; UDT binding tests will be added next.
Regarding mvnw test failures: they are caused only by the reverted non-PG
test files referencing removed placeholder fields. Once the PostgreSQL-only
tests are updated as described above, the build will pass again.
Next step:
- Add the remaining PostgreSQL UDT binding tests and ensure full test
coverage for JSON/JSONB/VARBIT/UDT scenarios.
Thank you again for the review. The PR is now narrowly scoped, low-risk,
and focused on the actual protocol correctness issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
