mdedetrich commented on code in PR #2409:
URL: https://github.com/apache/pekko/pull/2409#discussion_r2560538712
##########
.scala-steward.conf:
##########
@@ -5,6 +5,8 @@ updates.pin = [
{ groupId = "org.scala-lang", artifactId = "scala3-library", version =
"3.3." }
# sbt-assembly 2.3 causes build issues
(https://github.com/apache/pekko/pull/1744)
{ groupId = "com.eed3si9n", artifactId = "sbt-assembly", version = "2.2." }
+ # zstd-jni upgrades are fine as long as they are backwards compatible
+ { groupId = "com.github.luben", artifactId = "zstd-jni", version = "1."}
Review Comment:
> Shouldn't we even allow major version updates? Then we can decide on a
case-by-case basis whether the incompatibility that caused them to bump the
major version is a reason for us to avoid the update.
Well on the premise of it following semver doing major version updates could
be problematic because it can imply behaviour and/or API changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
