mdedetrich commented on PR #2409: URL: https://github.com/apache/pekko/pull/2409#issuecomment-3508172320
I have just updated the PR by adding our own `ZstdDictionary` datastructure so that the public API of the zstd compress/decompress doesn't depend on any internals from zstd-jni. Aside from making it possible to swap out zstd-jni in the future for any alternative implementations it also makes the API cleaner for both scala and java users. @He-Pin @pjfanning @raboof Let me know if the design `ZstdDictionary` works (I made it idiomatic for both scala and javadsl) and also that its location (i.e. `org.apache.pekko.stream.javadsl.compression.ZstdDictionary`/`org.apache.pekko.stream.scaladsl.compression.ZstdDictionary`) is appropriate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
