raboof commented on code in PR #2409: URL: https://github.com/apache/pekko/pull/2409#discussion_r2556773317
########## stream/src/main/scala/org/apache/pekko/stream/javadsl/compression/ZstdDictionary.java: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.stream.javadsl.compression; + +import org.apache.pekko.annotation.InternalApi; +import org.apache.pekko.stream.impl.io.compression.ZstdDictionaryImpl; +import org.apache.pekko.util.ByteString; +import org.apache.pekko.util.OptionalUtil; +import scala.Option; + +import java.util.OptionalInt; + +/** + * @since 2.0.0 + */ +public class ZstdDictionary { + byte[] dictionary; Review Comment: Is this somehow a standardized "zstd thing" or something still tied to this particular implementation? I think that needs to be documented. We could consider keeping the dictionary-related things `@ApiMayChange` to expedite the mergability of this PR while still giving us room to iterate later. ########## stream/src/main/scala/org/apache/pekko/stream/impl/io/compression/ZstdCompressor.scala: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.stream.impl.io.compression + +import java.nio.ByteBuffer +import com.github.luben.zstd.{ ZstdDictCompress, ZstdDirectBufferCompressingStreamNoFinalizer } +import org.apache.pekko +import org.apache.pekko.stream.scaladsl.Compression +import pekko.annotation.InternalApi +import pekko.util.ByteString + +/** INTERNAL API */ +@InternalApi private[pekko] class ZstdCompressor( + compressionLevel: Int = + Compression.ZstdDefaultCompressionLevel, dictionary: Option[ZstdDictionaryImpl] = None) extends Compressor { + + private val targetBuffer = ByteBuffer.allocateDirect(65536) + private val compressingStream = new ZstdDirectBufferCompressingStreamNoFinalizer(targetBuffer, compressionLevel) + + dictionary.foreach { dict => Review Comment: (nit: I find `match` almost always easier to read compared to `foreach` on `Option`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
