GitHub user mdedetrich edited a comment on the discussion: Replace typesafe config for sconfig for Pekko 2.0.0
Thanks for chiming in! So I just did a PR that migrates from Lightbend config to typesafe config and it was as trivial as expected https://github.com/apache/pekko/pull/2187. All tests pass and the only somewhat annoying thing we had to deal with was Scala source code, specifically the auto tupling/untupling of `()` (newer versions of Scala deprecate this). One thing that I realize that is missing, which was brought up by @janjaali at https://github.com/apache/pekko/discussions/2186#discussioncomment-14362061 is that we will need a conversion library from `org.ekrich.config.Config` to `com.typesafe.config.Config` and vice versa. This is because we have modules such as https://github.com/apache/pekko-persistence-jdbc which have a major internal dependency that uses lightbend config (in this case Slick) and we directly pass the lightbend config object to slick (see https://github.com/apache/pekko-persistence-jdbc/blob/8e9b0129fe448b3601db1386f3cbaabf499ebda6/core/src/main/scala/org/apache/pekko/persistence/jdbc/config/PekkoPersistenceConfig.scala#L26-L30). So aside from such a conversion library being helpful for users who still manually use lightbend config a lot and cannot move away from it, libraries such as pekko-persistence-jdbc will need to use it directly in order to convert a `org.ekrich.config.Config` to a `com.typesafe.config.Config` to pass it to slick. To me the natural place for such a library would be a separate artifact that sits in https://github.com/ekrich/sconfig. It wouldn't be part of the core library, so it can only be selectively included by the users that need it. I was thinking of contributing this, would you be open to it (unless you really feel like doing it yourself!). Logistically speaking this is the only blocker I can think of for pekko in deciding whether to adopt sconfig or not. GitHub link: https://github.com/apache/pekko/discussions/2186#discussioncomment-14367491 ---- This is an automatically sent email for notifications@pekko.apache.org. To unsubscribe, please send an email to: notifications-unsubscr...@pekko.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
