He-Pin commented on code in PR #1021: URL: https://github.com/apache/pekko-connectors/pull/1021#discussion_r2060121972
########## google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/AccessTokenCredentials.scala: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * This file is part of the Apache Pekko project, which was derived from Akka. + */ + +/* + * Copyright (C) since 2016 Lightbend Inc. <https://www.lightbend.com> + */ + +package org.apache.pekko.stream.connectors.google.auth + +import org.apache.pekko +import pekko.annotation.InternalApi +import pekko.http.scaladsl.model.headers.OAuth2BearerToken +import pekko.stream.connectors.google.RequestSettings +import com.google.auth.{ Credentials => GoogleCredentials } +import com.typesafe.config.Config + +import java.net.URI +import java.util +import scala.concurrent.{ ExecutionContext, Future } + +@InternalApi +private[auth] object AccessTokenCredentials { + def apply(c: Config): AccessTokenCredentials = AccessTokenCredentials(c.getString("project-id"), c.getString("token")) Review Comment: we may need a java api with create method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org