mdedetrich opened a new pull request, #1021: URL: https://github.com/apache/pekko-connectors/pull/1021
This PR modifies `NoCredentials` so that you aren't forced to provide it with a token. More specifically, the constructor for `NoCredentials` has been changed so that it doesn't have a `token` parameter and the `token` value from typesafe config is no longer retrieved. In order to get this to work, I had to split out the `get()` method (which returns the token) from `Credentials` into a separate `RetrievableCredentials` trait and every subclass of `Credentials` aside from `NoCredentials` inherits this trait. This main reason for this change is that `NoCredentials` shouldn't, by design, add token auth headers (the official analogue from Google's own sdk [doesn't do this](https://github.com/googleapis/sdk-platform-java/blob/main/java-core/google-cloud-core/src/main/java/com/google/cloud/NoCredentials.java)). The change is also being done in context of adding support for [fake-gcs-server](https://github.com/fsouza/fake-gcs-server) where their own sample JDK implementation also has [doesn't have to provide any token](https://github.com/fsouza/fake-gcs-server/blob/main/examples/java/src/test/java/com/fsouza/fakegcsserver/java/examples/FakeGcsServerTest.java#L25-L30) Note that all of the touched code is dealing with internals that are marked with `DoNotInherit`/`private` so it doesn't break binary compatibility in any way. It could be argued that this is a behaviour change and so it should only land for pekko-connectors 1.2.x however an alternate view is that `NoCredentials` would have only be used for testing (I highly doubt anyone would be using in prod, but it is theoretically possible) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
