mdedetrich commented on code in PR #1021: URL: https://github.com/apache/pekko-connectors/pull/1021#discussion_r2020103966
########## google-fcm/src/test/scala/org/apache/pekko/stream/connectors/google/firebase/fcm/v1/impl/FcmSenderSpec.scala: ########## Review Comment: I didn't bother adding a test here to make sure that the authorization header is being added for non `NoCredentials` credentials provider but I ca do it on request. Its also unclear if these are meant to be proper tests or tests asserting that the docs are written clearly??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
