mdedetrich commented on code in PR #1819: URL: https://github.com/apache/pekko/pull/1819#discussion_r2052674972
########## stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala: ########## @@ -1643,7 +1644,10 @@ abstract class GraphStageLogic private[stream] (val inCount: Int, val outCount: * * Typical use cases are exchanging messages between stream and substreams or invoking from external world sending * event to a stream + * + * Not for user extension */ +@DoNotInherit Review Comment: So I am not seeing why this trait per se would be problematic to extend, it does seem generic enough users could plausibly want to provide their own implementation. The newly added method however does seem like it shouldn't be extended, in which case you would make it `final`. Or am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
