pjfanning commented on code in PR #1819: URL: https://github.com/apache/pekko/pull/1819#discussion_r2052654133
########## stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala: ########## @@ -1643,7 +1644,10 @@ abstract class GraphStageLogic private[stream] (val inCount: Int, val outCount: * * Typical use cases are exchanging messages between stream and substreams or invoking from external world sending * event to a stream + * + * Not for user extension */ +@DoNotInherit Review Comment: The trait has been as is for a while. I am struggling to understand why this PR needs to change the docs and annotations about whether this trait is extensible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
