mdedetrich commented on code in PR #1819: URL: https://github.com/apache/pekko/pull/1819#discussion_r2052649781
########## stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala: ########## @@ -1643,7 +1644,10 @@ abstract class GraphStageLogic private[stream] (val inCount: Int, val outCount: * * Typical use cases are exchanging messages between stream and substreams or invoking from external world sending * event to a stream + * + * Not for user extension */ +@DoNotInherit Review Comment: Not sure if applicable but `@DoNotInherit` doesn't indicate that it can never be inherit, just that it shouldn't be inherited by users of Pekko. The Pekko library itself can inherit it as much as it wants. The reason this annotation exists is because of limitations in Java, i.e. Java has no concept of sealed like Scala/Kotlin has -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
