pjfanning commented on code in PR #1004:
URL: https://github.com/apache/pekko-connectors/pull/1004#discussion_r1997547153


##########
udp/src/main/scala/org/apache/pekko/stream/connectors/udp/impl/UdpBind.scala:
##########
@@ -62,6 +63,9 @@ import scala.concurrent.{ Future, Promise }
       if (isAvailable(out)) {
         push(out, Datagram(data, sender))
       }
+    case (_, Terminated(_)) =>
+      listener = null
+      failStage(new IllegalStateException("UDP listener terminated 
unexpectedly"))

Review Comment:
   ConnectionException has a good name but its Javadoc is a bit specific.
   
   > Signals that an error occurred while attempting to connect a socket to a 
remote address and port. Typically, the connection was refused remotely (e.g., 
no process is listening on the remote address/port).
   
   Would a plain IOException be an option?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to