mdedetrich commented on code in PR #1004:
URL: https://github.com/apache/pekko-connectors/pull/1004#discussion_r1996679882
##########
udp/src/main/scala/org/apache/pekko/stream/connectors/udp/impl/UdpBind.scala:
##########
@@ -62,6 +63,9 @@ import scala.concurrent.{ Future, Promise }
if (isAvailable(out)) {
push(out, Datagram(data, sender))
}
+ case (_, Terminated(_)) =>
+ listener = null
+ failStage(new IllegalStateException("UDP listener terminated
unexpectedly"))
Review Comment:
I am wondering whether a `Runtime` exception is better suited to this than
an `IllegalStateException` @raboof @pjfanning wdyt?
I am also wondering if there is an already existing better exception that
could be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
