janjaali commented on code in PR #267:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/267#discussion_r1948133226
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/javadsl/JdbcReadJournal.scala:
##########
@@ -32,7 +38,8 @@ class JdbcReadJournal(journal: ScalaJdbcReadJournal)
with CurrentEventsByPersistenceIdQuery
with EventsByPersistenceIdQuery
with CurrentEventsByTagQuery
- with EventsByTagQuery {
+ with EventsByTagQuery
+ with CurrentLastKnownSequenceNumberByPersistenceIdQuery {
Review Comment:
Main intent was to stick to existing marker traits application + having that
part of contract testable on its own. In our applications we rarely declare
dependencies to the full query journal, usually we tend to have the
capabilities speaking:
```scala
object FancyAggregator {
def apply(readJournal: EventsByTagQuery)
}
```
vs
```scala
object FancyAggregator {
def apply(readJournal: JdbcReadJournal)
}
```
If you feel more comfortable, surely, I can try to inline it without marker
trait. Would make dependency injection a bit harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
